https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40445
--- Comment #209 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 202942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202942&action=edit Bug 40445: (follow-up) Move TT values out of kohaTable script blocks xt/tt_kohaTable_tidy.t forbids mixing Template::Toolkit tags with .kohaTable() calls inside the same <script> block, since such blocks are expected to be pure JS. The cashup modal init calls in pos/register.tt and pos/registers.tt embedded TT-derived values (bankable amount, register float, reconciliation note settings, cashup progress) directly alongside kohaTable() initialisation, tripping the check. This moves those TT expressions into the existing TT-tag-only <script> block that precedes the kohaTable block in each template, exposing them as a plain JS object (cashupModalData) that the kohaTable block then reads. Test plan: 1. Apply the patch. 2. prove xt/tt_kohaTable_tidy.t -- register.tt and registers.tt should no longer be listed among the failures. 3. Load the POS register and registers pages, confirm the trigger and confirm cashup modals still receive the correct bankable amount, register float, and reconciliation note settings. Sponsored-by: OpenFifth <https://openfifth.co.uk/> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
