https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605
--- Comment #1 from Andrii Nugged <[email protected]> --- Created attachment 203731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203731&action=edit Bug 42605: Preserve acquisition preference string values Bug 41563 converted AcqCreateItem and UniqueItemFields to booleans when adding them to Koha.prefs. Both preferences are strings: AcqCreateItem controls where items are created, while UniqueItemFields contains a pipe-separated list. When a basket inherits AcqCreateItem=ordering, the boolean value matches none of the receiving page branches and existing items are hidden. When items are created on receiving, the numeric UniqueItemFields value also fails when the page calls split(). Preserve both string values in Koha.prefs. Add a Cypress regression test which renders orderreceive.pl and verifies the values exposed to JavaScript. Test plan: 1. Set AcqCreateItem to "placing an order". 2. Create a basket which uses the system preference, add an order with an item, close the basket, and receive a shipment. 3. Confirm the existing item and its Receive checkbox are displayed. 4. Set the basket to create items when receiving and confirm the item creation form opens without a UniqueItemFields.split error. 5. Run: yarn cypress run --spec \ t/cypress/integration/Acquisitions/OrderReceivePreferences_spec.ts Co-Authored-By: Loontik <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
