https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41728
--- Comment #123 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 204899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204899&action=edit Bug 41728: (QA follow-up) Remove leftover duplicate data-consistency block d43945e7279 moved the issued/patron data-consistency check earlier in AddReturn (before blocker handling), as its commit message describes, but only copied the block instead of deleting the original. The leftover block ran unconditionally afterwards: since $patron is already guaranteed set whenever $issue is true by that point, its "else" branch fired on every normal checkin of an already-issued item, incorrectly setting $messages->{NotIssued} and clearing item.onloan. This corrupted the not_issued message surfaced to circ/returns.pl, SIP, and the checkin audit record on every ordinary return. The same leftover block also buried $iso18626_request's assignment after a die (making it dead code), so ISO18626 progress-reporting on checkin was never triggered. Restore the assignment at the point $issue/$patron are extracted from the availability context, where it belongs. Test plan: 1. Return an item that is currently checked out. 2. Confirm the returned $messages hashref no longer contains a NotIssued key, and that item.onloan is only cleared for items that were genuinely not checked out. Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
