https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42623
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Andrew Fuerste-Henry <[email protected]> --- When LimitReportsBy is set to "library group" and a report does not have any library limitations, this allows any library to be selected. But when LimitReportsBy is set to "library" and a report does not have any library selected this only allows the logged-in library to be selected. It would make more sense to me to treat these consistently: - If LimitReportsBy is set to "no restriction," all libraries appear in the dropdown - If LimitReportsBy is set to "library," reports without restrictions show all libraries in the dropdown and reports with restrictions only show the libraries to which they are restricted - If LimitReportsBy is set to "library groups," reports without restrictions show all libraries in the dropdown and reports with restrictions only show the libraries to which they are restricted and any libraries in a reports group with those libraries But this removes the option to restrict a user to only getting data about their logged-in branch. Smaller issue: there's a test failure due to incorrect test count: Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/Koha/Reports.t (Wstat: 65280 (exited 255) Tests: 22 Failed: 1) Failed test: 22 Non-zero exit status: 255 Parse errors: Bad plan. You planned 21 tests but ran 22. Files=1, Tests=22, 2 wallclock secs ( 0.01 usr 0.01 sys + 1.64 cusr 0.30 csys = 1.96 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
