https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39419
--- Comment #64 from Brendan Lawlor <[email protected]> --- Created attachment 207668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207668&action=edit Bug 39419: (QA follow-up) Set patron_expiration_date for Club and ILS-DI holds AddReserve's expiration_date parameter used to set patron_expiration_date. It now sets expirationdate, and patron_expiration_date has its own parameter. Club holds and the ILS-DI HoldTitle and HoldItem services still passed the requester's date only as expiration_date, so patron_expiration_date was no longer set for these holds. set_waiting and revert_found both rely on it. This patch passes the date to both parameters, like the OPAC and staff interface do. Test plan: 1. In KTD, enable the ILS-DI system preference and set ILS-DI:AuthorizedIPs to 0.0.0.0/0 2. Place a hold through ILS-DI: curl -s 'http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=42&bib_id=1&request_location=127.0.0.1&expiry_date=2099-01-01' 3. Check the new hold: SELECT reserve_id, expirationdate, patron_expiration_date FROM reserves ORDER BY reserve_id DESC LIMIT 1 4. Note expirationdate is 2099-01-01 but patron_expiration_date is NULL 5. Cancel that hold 6. Apply patch and restart_all 7. Repeat steps 2 and 3 8. Note both expirationdate and patron_expiration_date are 2099-01-01 9. Run: prove t/db_dependent/ILSDI_Services.t t/db_dependent/Koha/Club/Hold.t t/db_dependent/api/v1/clubs_holds.t Sponsored-by: CLAMS Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Brendan Lawlor <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
