https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43624

--- Comment #4 from Owen Leonard <[email protected]> ---
Created attachment 207900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207900&action=edit
Bug 43624: (follow-up) Don't break uncertainprice.pl after saving prices

After saving the prices, uncertainprice.tt only renders a redirection:
the "Show orders from" filter form is not displayed, but the new script
still adds a listener to it, which throws a JavaScript error:

TypeError: Cannot read properties of null (reading 'addEventListener')

Only add the listener if the filter is on the page.

To test:
1. Create an order with an uncertain price:
   - Go to Acquisitions, search for a vendor and open one of its
     baskets (or create a new basket).
   - Click "Add to basket" and choose whatever you want.
   - In the order form, under "Accounting details", fill in the
     quantity, choose a fund and check "Uncertain price".
   - Save the order.
2. Click "Uncertain prices" => menu on the left
3. Open the browser console. Click on Setting (icon) and enable
   "Preserve log" => necessary because  the page is reloaded after
   saving.
4. Change the price of the order. Click "Save": the TypeError is
   displayed in the console.
5. Apply this patch.
6. Repeat step 4: no more error, the new price is saved.

Signed-off-by: Owen Leonard <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to