https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37985
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |Failed QA --- Comment #21 from David Nind <[email protected]> --- I've Failed QA when attempting to test because of the test plan and qa script failures. Can the test plan be updated please? It seems to be missing some steps and the sequence is unclear to me, after spending some time attempting to test: 1. When do I apply the patches? 2. What should I see before and after the patches: - no results before? I assume that us the case with step 2b - X results after? I didn't get any results after 3. No mention of database update required, and restart 4. Doing a reindex is mentioned, however what is the difference between: - koha-elasticsearch --rebuild -r kohadev and - koha-elasticsearch --rebuild -d -b -a kohadev (what I normally do for a full reindex) 5. For the second patch, what should I see or is just facets in general? That is are they broken somehow before or just with the first patch? There are several qa script failures - tidiness, tests fail, filters, spelling and so on. See the list at the end. Testing notes - what I attempted (using KTD): 1. Run through steps 1 to 3 - Step 2: there is a comma at the end of the URL, I removed that - Step 3: save script in /kohadevbox/koha/record-updates.pl and then run: perl record-updates.pl 2. Apply the patches 3. Run the database update: databaseupdate 4. Restart everything: restart_all 5. Reindex everything - not sure what the difference is between: - how I normally do a reindex: koha-elasticsearch --rebuild -d -b -a kohadev - what is in the test plan: koha-elasticsearch --rebuild -r kohadev 6. Run through steps 5 to 6: I don't get any results Test failures ============= qa ... Result: [FAIL] C4/Search.pm FAIL pod_coverage sub _build_stemmed_operand has no pod coverage. sub _get_facets_from_records has no pod coverage. sub _detect_truncation has no pod coverage. sub _build_weighted_query has no pod coverage. [FAIL] Koha/Indexer/Utils.pm FAIL pod_coverage sub _append_grs1_defs_for_control_field has no pod coverage. sub _can_ignore_grs1_cfg_line has no pod coverage. sub _parse_xelm_melm has no pod coverage. sub _append_target_indexes has no pod coverage. sub _parse_grs1_index_def has no pod coverage. sub _parse_grs1_cfg_line has no pod coverage. sub _append_grs1_defs_for_leader has no pod coverage. sub _append_one_target_index has no pod coverage. sub _append_grs1_def_to_dom_cfg has no pod coverage. [SKIP] Koha/Schema/Result/SearchField.pm SKIP pod_coverage No POD exists [WARN] Koha/SearchEngine/Elasticsearch.pm WARN spelling refering ==> referring [PASS] Koha/SearchEngine/Elasticsearch/QueryBuilder.pm [PASS] Koha/SearchEngine/Elasticsearch/Search.pm [PASS] admin/searchengine/elasticsearch/field_config.yaml [PASS] admin/searchengine/elasticsearch/mappings.yaml [FAIL] installer/data/mysql/atomicupdate/bug_37985.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/bug_37985.pl` [PASS] installer/data/mysql/kohastructure.sql [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt` [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/resort_form.inc [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt FAIL filters missing_filter at line 341 ( data-biblionumber="[% SEARCH_RESULT.biblionumber %]") missing_filter at line 342 ( data-title="[% SEARCH_RESULT.title %]") missing_filter at line 343 ( data-geolocation="[% To.json(SEARCH_RESULT.geolocation) %]") missing_filter at line 350 ( data-biblionumber="[% SEARCH_RESULT.biblionumber %]") missing_filter at line 351 ( data-title="[% SEARCH_RESULT.title %]") missing_filter at line 352 ( data-geolocation-area="[% To.json(SEARCH_RESULT.geolocation_area) %]") [FAIL] opac/opac-search.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl opac/opac-search.pl` [FAIL] t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t` Processing additional checks PASS! Running tests (1) * Proving /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t FAIL # Failed test 'should be able to create "distance from a point" queries' # at /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 432. # Structures begin differing at: # $got = undef # $expected = HASH(0x55673b3136e0) # Failed test 'should be able to create "within a bounding box" queries' # at /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 444. # Structures begin differing at: # $got = undef # $expected = HASH(0x55673b30ad40) # Looks like you failed 2 tests of 2. # Failed test 'geolocation queries' # at /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 451. # Looks like you planned 9 tests but ran 10. # Looks like you failed 1 test of 10 run. /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- /kohadevbox/koha/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t (Wstat: 256 (exited 1) Tests: 10 Failed: 2) Failed tests: 9-10 Non-zero exit status: 1 Parse errors: Bad plan. You planned 9 tests but ran 10. Files=1, Tests=10, 2 wallclock secs ( 0.01 usr 0.01 sys + 1.43 cusr 0.19 csys = 1.64 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
