https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43723
Paul Derscheid <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Paul Derscheid <[email protected]> --- Hi there, I am not sure whether it's just me but I find the first commit message (Use bitwise test in IsSuperLibrarian) confusing. It sounds like it switches to `& 1`, but the diff does `== 1`. Can this be updated? I am also not sure whether this is a problem, but IsSuperLibrarian can now disagree with the other superlibrarian checks: perl -MC4::Context -MC4::Auth -MKoha::Database -MKoha::Patrons -e ' my $s = Koha::Database->schema; $s->txn_begin; my $p = Koha::Patrons->search->next; $p->flags(3)->store; C4::Context->set_userenv( $p->borrowernumber, $p->userid, $p->cardnumber, "", "", "", "", 3 ); my %r = ( getuserflags => C4::Auth::getuserflags( 3, $p->userid )->{superlibrarian}, haspermission => C4::Auth::haspermission( $p->userid, { superlibrarian => 1 } ), has_permission => $p->has_permission( { superlibrarian => 1 } ), is_superlibrarian => $p->is_superlibrarian, IsSuperLibrarian => C4::Context->IsSuperLibrarian, ); $r{permissions} = $p->permissions->{superlibrarian} if $p->can("permissions"); printf "%-18s %d\n", $_, ( $r{$_} ? 1 : 0 ) for sort keys %r; $s->txn_rollback;' IsSuperLibrarian 0 getuserflags 1 has_permission 1 haspermission 1 is_superlibrarian 1 permissions 1 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
