https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42646
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Martin Renvoize (ashimema) <[email protected]> --- Thanks for testing, Lisette. The warning you hit ("transported by sms", expected "email") is what the third patch, "(QA follow-up) Mock FallbackToSMSIfNoEmail at top of Suggestions.t", fixes: the test patron has an SMS number but no email, so with FallbackToSMSIfNoEmail enabled in the database the transport resolves to sms. The mock makes the test independent of that setting. I can reproduce your failure with only the first two patches applied, and with all three applied Suggestions.t passes whether the preference is on or off in the database. Bug 42645 has now been pushed, so I have rebased the patches onto current main (dropping the 42645 commits), updated the test plan count, and kept the sign-off and sponsorship lines. Please make sure all three patches are applied when you test again. Setting back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
