https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43951

            Bug ID: 43951
           Summary: Patron name should not be a link in the heading of
                    pages about that patron
   Initiative type: ---
        Sponsorship ---
            status:
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]
                CC: [email protected]
  Target Milestone: ---

Bug 43220 and bug 43866 stopped the patron name and card number being a link in
the "Checking out to" headings and legend on the circulation pages. The patron
name is still a link in the <h1> of several other patron pages, where the page
is already about that patron:

- Sent notices (members/notices.pl)
- Account (members/boraccount.pl)
- Statistics (members/statistics.pl)
- Subscription routing lists (members/routing-lists.pl)
- API keys (members/apikeys.pl)
- Housebound details (members/housebound.pl)
- Modify patron / Duplicate patron (members/memberentry.pl)

This patch passes no_html = 1 to patron-title.inc in those headings, as is
already done in members/moremember.tt and members/member-flags.tt.

Breadcrumbs are deliberately left alone: the patron name there remains a link
back to the patron's details page. Headings that refer to a different patron
than the one being viewed (e.g. in returns.tt or merge-patrons.tt) are also
left alone.

Proposed guideline (for discussion): link the patron name when it is a pointer
to a patron the user is not currently viewing (tables, notes, alerts,
breadcrumbs), and render it as plain text when it is the heading or legend of a
page that is already about that patron.

Test plan:
1. Go to a patron's page and open each of: Notices, Accounting (Account tab),
Statistics, API keys, Routing lists (needs serials), Housebound (needs
HouseboundModule) and Modify patron.
2. Note the patron name and card number in the page heading are a link to the
patron's details page.
3. Apply the patch and reload each page.
4. Confirm the heading is plain text, and that the breadcrumb link to the
patron is unchanged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to