https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42077
--- Comment #12 from Mark Hofstetter <[email protected]> --- Created attachment 210873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210873&action=edit Bug 42077: (follow-up) Align polling defaults and optional broker upgrades Complete the polling default in the administration preference and both runtime fallbacks. Existing explicit STOMP settings and the historical database revision remain unchanged. Only enable the STOMP plugin and restart a local RabbitMQ service when an instance explicitly uses STOMP with a local broker. Enable the plugin offline so a stopped broker does not break package configuration. Polling instances, remote brokers and installations without instances do not trigger local RabbitMQ service operations. Report unavailable instance databases without failing package configuration. Add Debian NEWS and installation guidance explaining existing settings, worker restarts and the apt-mark manual command for retaining an automatically installed broker. Fix the trailing dependency comma and keep control and control.in consistent. Add service-behaviour regressions and cover missing and empty preference values. Mock the transport-specific unit tests so they no longer require a running broker when RabbitMQ is optional. Test plan: 1. Apply attachment 207312 and this follow-up on an isolated test system. 2. On a fresh installation confirm JobsNotificationMethod is polling. Search for the preference in administration: polling is selected and the explanation identifies it as the default. STOMP remains available. 3. Build the Debian packages. Confirm rabbitmq-server is only in Suggests for koha-common and koha-deps, and control matches control.in. 4. Install koha-core, koha-sysv (or koha-systemd) and koha-common. Confirm koha-common configures successfully without rabbitmq-server installed and a default apt reinstall does not pull it in. 5. Stop RabbitMQ on the isolated system. Enqueue a batch item update and confirm the worker finishes it and applies the requested item notes. 6. Temporarily rename the JobsNotificationMethod preference row, clear the syspref cache and start a worker. Repeat the job check: it must finish without attempting a broker connection. Restore the row and clear the cache afterward. 7. With polling selected, run koha-common's postinst configure action: the stopped RabbitMQ service must remain stopped. 8. Select STOMP and configure a remote broker hostname. Repeat the configure action: the local RabbitMQ service must remain stopped. 9. Configure localhost for STOMP with RabbitMQ installed but stopped. The configure action must enable STOMP offline and start the broker. Confirm the STOMP preference remains unchanged and an enqueued job completes through STOMP. 10. Read NEWS.Debian and README.Debian. They must explain that existing settings are preserved, workers remain required, and a local broker that is still needed can be protected using apt-mark manual. 11. Run with RabbitMQ stopped: prove xt/koha-common-postinst.t \ t/db_dependent/Koha/BackgroundJob.t \ t/db_dependent/Koha/BackgroundJobs.t \ t/db_dependent/Koha/BackgroundJob/BatchUpdateItem.t \ t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblio.t \ t/db_dependent/Koha/BackgroundJob/MARCImportCommitBatch.t \ t/db_dependent/Koha/BackgroundJob/StageMARCForImport.t The packaging test includes mixed instances, missing/empty values, loopback addresses, local hostnames and an unavailable database. 12. Restore polling and restart both worker queues for further tests. Co-authored-by: OpenAI Codex <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
