https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43910
--- Comment #9 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 210937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210937&action=edit Bug 43910: (QA follow-up) Do not use Template Toolkit tags in the script tag The previous patch added an [% UNLESS Koha.Preference('RequireCashRegister') %] block to a <script> tag that must not contain Template::Toolkit tags, which xt/tt_script_tidy.t rejects. Template::Toolkit tags are only allowed in the single <script data-tt-allowed="true"> tag of the page. The RequireCashRegister preference is now passed to the script with the other preferences, in Koha.addPrefs, and tested in JavaScript. The behaviour does not change. To test: 1. Apply the patches 2. prove xt/tt_script_tidy.t => SUCCESS: Tests pass! (before the patch: boraccount.tt has a <script> tag with Template::Toolkit tags) 3. With UseCashRegisters enabled and RequireCashRegister disabled, choose Cash in the "Issue payout" modal: the Cash register field is marked as required 4. With RequireCashRegister enabled, it is not marked 5. Sign off :-D Co-Authored-By: Claude Sonnet 5.5 <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
