https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608

--- Comment #90 from Christian Stelzenmüller 
<[email protected]> ---
Created attachment 210230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210230&action=edit
Bug 41608: (QA follow-up) Fix multi-choice limits round trip and facet links

QA reported that mixing the multi-choice flow (checkboxes + "Apply")
and the single-limit flow (clicking a facet link) broke the search:
after selecting "Centerville" and "Books" and applying, clicking the
"Books" facet link returned no result, with limits like
'holdingbranch:""CPL"" mc-mc-itype:BK itype:BK'.

The multi-choice limits are now regenerated in the CGI query in a
normalized form (the "mc-" prefix is kept exactly once, the quotes of
the values are normalized), so they survive the round trip whatever
quoting they carry.

The facet links now switch to the single-limit (AND) flow when
MultiChoiceFacets is enabled: they are built without the multi-choice
(OR) limits, so clicking a facet label applies it on its own, as if it
was clicked in the first place. The selected facets are also marked as
active (checked checkboxes, not hidden by the "Show more" toggle) even
when they are carried by multi-choice limits.

Test plan:
- enable MultiChoiceFacets
- search for "complete", check "Centerville" and "Books", click "Apply"
  (3 results)
- click the "Books" facet label: the multi-choice limits are dropped and
  the result is the same as clicking "Books" in the first place (9
  results)
- run t/cypress/integration/Search/MultiChoiceFacets_spec.ts with Cypress
- repeat on the OPAC

Signed-off-by: Christian Stelzenmüller <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to