https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #40 from Martin Renvoize (ashimema) <[email protected]> --- Thanks Lucas. This patch had not been tested for a long time, so I rebased it on current main, ran it, and brought it up to date. The code of the first patch is still Julian's, with what I had to change listed in its commit message. Your QA script failures: * The column is now tinyint(1) in kohastructure.sql and the atomicupdate, and is a boolean in the schema (is_boolean, in its own commit as usual). The vendor_edi_accounts.po_is_basketname failure was not about this bug: it came from the old "DBIC Build" patch, which had been generated from a different database. It is replaced by an "Automated Schema Update" commit that only changes the subscription table, and the boolean flag commit. * The licence header of the cron job used http://, it uses https:// now. Problems found by running it, both fixed in the first patch: * GetLateOrMissingIssues selected serial.aqbooksellerid. That column only exists in the subscription table now, so the query failed ("Unknown column"), which also broke t/db_dependent/Serials/Claims.t and the claims page of the staff interface. It is aqbooksellerid again. * The cron job died at once, as it called cronlogaction without importing it. Koha::Script -cron already does that logging, so the call is removed. Other changes to the first patch: it conflicted with main (the new preselect_issues_in_collections_table column is added in the same places), the atomicupdate is named bug_18783.pl as the others and uses the output helpers, and the script is renamed from serialsClaim.pl to claim_serials.pl, like the other recent scripts. New follow-up patches, so that the script no longer needs a server administrator to give it options: * The claim notice and the maximum number of claims are set in the Serials system preferences (SerialsClaimLetter, a dropdown of the email notices of the "Claim serial issue" module, and SerialsMaxClaims, 3 by default, 0 for no limit). The script uses Koha::Script->describe_options; --letter-code and --max-claims stay as optional options that win over the preferences, so existing command lines keep working. It stops, saying which preference to set, if there is no notice. There is also an example line in crontab.example. * t/db_dependent/cronjobs/claim_serials.t, as there was no test. It checks the notice used, which issues are claimed (automatic claims enabled on the subscription, delivery time of the supplier passed, not claimed again before it has passed again) and the maximum number of claims. To remember how it works: an issue that was claimed is claimed again, with the same notice, each time the delivery time of its supplier has passed since the last claim, until the maximum is reached. Settings per supplier, such as a different notice or delay for each claim, would be a separate enhancement. koha-qa is clean, except for the pod_coverage of C4/Serials.pm, which is about private subs that this bug does not touch. The test plans are in the commit messages. Setting back for testing. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
