http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937
David Cook <dc...@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |dc...@prosentient.com.au --- Comment #3 from David Cook <dc...@prosentient.com.au> --- I'm glad that someone has worked on this issue as I was just talking about it a few hours ago! However: 1) There is an issue with your code in regards to "Search Category". If an item type has a "search category" of none, it won't appear on the Advanced Search page. That is...if "searchcategory" is null in the database and "hideinopac" is 0, the item type will appear. However, if "searchcategory" is blank and "hideinopac" is 0, the item type will be hidden. "searchcategory" will be blank any time an item type is saved and "None" is selected as the Search Category. Definitely not a good thing! There are a few other things that you will also want to consider in revising your patch: 2) Whitespace changes should be made in a separate patch so it's easier to separate code differences and format differences (like in kohastructure.sql). 3) You have a typo on the Add/Edit item type page (http://devonestaff/cgi-bin/koha/admin/itemtypes.pl?op=add_form). It says "Advanded Search" rather than "Advanced Search". -- You might want to also consider the following: 4) Your test plan assumes that there is an authorized value category of "DOCTYPECAT". You should mention that most users will probably have to create this authorized value category. Also, your test plan says to choose "Hardware" in the staff client, but the authorized value will actually be "Anything" according to your plan. Of course, it should be the only search category available (other than none), but the test plan is a rather dense block of text, so I found it difficult to tell exactly what I was supposed to see. It might be useful to add some whitespace between the test plan steps to make it easier to read. -- I'll be happy to look again once you have an updated patch! Thanks, Philippe. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/