http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807
Jonathan Druart <jonathan.dru...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.dru...@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.dru...@biblibre.com> --- I am a little bit disconcerted. The aqbasketgroup.tt is really dirty and it is not easy to do something in it. But this patch is not really clear: 1/ I don't know if to add a lot of simple comment is useful (in the pl file). 2/ The view "show" is not clear in the code. Personally, I don't understand anything. 3/ There is some useless loop: [% FOREACH billingplaceloo IN billingplaceloop %] [% IF ( billingplaceloo.selected ) %] <input name="billingplace" id="billingplace" type ="hidden" value="[% billingplaceloo.value %]" />[% billingplaceloo.branchname %] [% END %] [% END %] It is not a logic way to display an input. 4/ There is a mix between new code and indentation fixes (use the -w option for git show). 5/ There is no "show" view for the opened bg. And for the closed bd, the "show" view is accessible on click on a button. Why there is no a simple "show" op and a link on the bg name? I let someone else from the QA team to give his/her opinion on this patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/