http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096
--- Comment #12 from Tomás Cohen Arazi <tomasco...@gmail.com> ---
(In reply to Chris Cormack from comment #10)
> Tomás, the second patch conflicts here
>
> <<<<<<< HEAD
> my $marcrecord = eval { MARC::File::USMARC::decode(
> $marcresults->[$i] ); };
> if ( $@ ) {
> warn "ERROR DECODING RECORD - $@: " . $marcresults->[$i];
> next;
> }
>
> =======
> my $marcrecord = MARC::Record->new_from_xml(
> $marcresults->[$i],
> 'UTF-8'
> );
> >>>>>>> Bug 11096: force XML syntax for Zconn
>
> I think because the eval was recently introduced, should we be evaling for
> new_from_xml or does it handle errors better than MARC::File::USMARC::decode
> does?
MARC::File::XML->new_from_xml implicitly calls its own decode method, which
also croaks if problems arise decoding. So I attached a rebased patch that
preserves that introduced behaviour (I mean the eval).
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
