http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #18 from Jonathan Druart <jonathan.dru...@biblibre.com> --- (In reply to Kyle M Hall from comment #17) > The code is an extension of the addition of lists to the patron modification > tool. I understand what you mean. However I'd suggest that over time we, > instead of having two separate tools that function in different ways, unify > both the existing patron modification and deletion tools in a manner > equivalent to the batch item and modification deletion which is just the > same script with a flag passed in for deletion. I don't think the batch item mod/del is a good example :) The code is not clean and not easy to read/understand. I think it is a good thing to keep 2 pages and 2 scripts: 1 for the deletion and 1 for the modification. The borrower modification script has 400 lines and will be difficult to maintain if it grows too much. Moreover the "Delete patrons" checkbox is not ergonomic, I think: the user can edit patron fields and at the same time, delete patrons. Maybe should we have another point of view. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/