http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #88 from Katrin Fischer <katrin.fisc...@bsz-bw.de> ---
Comment on attachment 22877
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22877
Bug 7825: Changed OPACItemHolds syspref to be no|tes|force choice

Review of attachment 22877:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7825&attachment=22877)
-----------------------------------------------------------------

Hi Jonathan,

in your comment you wrote:
The value field should not be change. We have to keep '1' for 'yes' and ''
for 'no'.

But I still see the yes/no in the database update and syspref part?

::: installer/data/mysql/sysprefs.sql
@@ +228,4 @@
>  ('OpacHiddenItems','','','This syspref allows to define custom rules for 
> hiding specific items at opac. See docs/opac/OpacHiddenItems.txt for more 
> informations.','Textarea'),
>  ('OpacHighlightedWords','1','','If Set, then queried words are higlighted in 
> OPAC','YesNo'),
>  ('OpacHoldNotes','0','','Show hold notes on OPAC','YesNo'),
> +('OPACItemHolds','yes','no|yes|force','Allow OPAC users to place hold on 
> specific items. If No, users can only request next available copy. If Yes, 
> users can choose between next available and specific copy. If Force, users 
> *must* choose a specific copy.','Choice'),

Should be 0 and 1?

::: installer/data/mysql/updatedatabase.pl
@@ +7745,5 @@
>  
> +
> +$DBversion = "3.13.00.XXX";
> +if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
> +    $dbh->do("UPDATE systempreferences SET type = 'Choice', options = 
> 'no|yes|force' WHERE variable = 'OPACItemHolds'");

Should be 0 and 1?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to