http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8168
--- Comment #4 from M. Tompsett <mtomp...@hotmail.com> --- Comment on attachment 24321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24321 Bug:8168 Fixing header of non csv files Review of attachment 24321: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8168&attachment=24321) ----------------------------------------------------------------- ::: misc/cronjobs/overdue_notices.pl @@ +628,5 @@ > } > # Generate the content of the csv with headers > + my $content; > + if ( defined $csvfilename ) { > + $content = join(";", qw(title name surname address1 > address2 zipcode city country email itemcount > itemsinfo due_date issue_date)) . "\n"; You missed Galen's second comment. The ";" should refer to C4::Context->preference('delimiter') I believe. You also have tab issues. @@ +634,5 @@ > + else { > + $content = ""; > + } > + $content .= join( "\n", @output_chunks ); > + This should be a blank line, not something with a tab or spaces. mtompset@ubuntu:~/kohaclone$ koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 1cc0d7b 'Bug 10907: (follow-up) fix table sort') FAIL misc/cronjobs/overdue_notices.pl OK pod FAIL forbidden patterns forbidden pattern: tab char (line 637) forbidden pattern: tab char (line 633) forbidden pattern: tab char (line 630) forbidden pattern: tab char (line 635) forbidden pattern: tab char (line 631) forbidden pattern: tab char (line 636) forbidden pattern: tab char (line 634) forbidden pattern: tab char (line 632) OK valid OK critic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
