http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11917
M. de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.r...@rijksmuseum.nl --- Comment #6 from M. de Rooy <m.de.r...@rijksmuseum.nl> --- QA Comment: I appreciate the idea behind the patch, but do not really see the actual benefits of this code. Without DEBUG=1 (as we assume in normal operation), I do not see any difference. I think that the routine in Members, PutPatronImage, should be addressed in this report. It combines the insert into patronimage with the select on cardnumber. It could check cardnumber first. Note that if I see "There is a database error. See the log", I would rather see the error message right away. And the message is passed back by PutPatronImage. Failed QA -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/