http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11913
Jonathan Druart <jonathan.dru...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26052|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.dru...@biblibre.com> --- Created attachment 26411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26411&action=edit Bug 11913 - [SIGNED-OFF] Attributes generate error log during member entry In member/memberentry.pl, there were two lines like: my $newentry = { map { $_ => $entry->{$_} } %$entry }; These were in the 'sub patron_attributes_form'. They have been changed to: my $newentry = { %$entry }; Of course, indentation does not reflect actual indentation. They were discovered while testing another bug, which required editing a member record. TEST PLAN --------- 1) Make sure you have the SHOW_BCODE attribute. 2) Go edit a member. 3) Clear the SHOW_BCODE value. 4) Save. 5) Edit again. 6) Check the error log file. 7) apply patch. 8) Change the value for SHOW_BCODE (Yes/No) 9) Save. 10) Edit again. (tests change 1) 11) Clear the SHOW_BCODE 12) Save. 13) Edit again. (tests change 2) 14) Check the error log file. Signed-off-by: Magnus Enger <digitalutvikl...@gmail.com> Tested with the SHOW_BCODE attribute, setting it to empty, Yes and No. The patch removes the error log messages, as described. Signed-off-by: Jonathan Druart <jonathan.dru...@biblibre.com> The existing code is really weird, I did not find any usefulness to have values in keys. No regression found. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/