http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885
--- Comment #8 from paxed <pasi.kalli...@pttk.fi> --- (In reply to M. Tompsett from comment #7) > Created attachment 26773 [details] [review] > Bug 11885 - Follow-up to address issues raised > > This patch addresses them in the following way: > 1/ You will note that @ was not bold on the 0 tab. > Every other tab were bold. By making the similar template > into a procedure based on the 0XX tab, bolding was lost. > This patch bolds all subtags including the @, so that > the visible change is minimized. Why hard-coded <b> tags? Isn't there some good reason to separate presentation and content? > 2/ The dash was programmatically added in at the code stage > previously. This bug fix splits the the single concatenation > mess into parts which can be styled. This puts the dash back > into the template. However, it should be noted that the > spacing for the 0 tab's tag and tag description will have an > extra space after the hypen that was lacking before. Wrap the dash and the spaces before the description in <span class="dashwrapper"> or something, so it'll be easier to hide with css. > 3/ <span>...</span><span>...</span> is different than > <span>...</span> > <span>...</span> > The later puts that extra space. This patch fixes that. This one is good. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/