http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947
--- Comment #24 from Galen Charlton <gmcha...@gmail.com> --- The bug itself appears to be a regression caused by the patch for bug 9394. Specifically, the checkin sequence for circ/returns.pl does this: - ModReserveAffect(), which prior to Robin's proposed patch did not alter the priorities of other holds, just the one whose item is being set to waiting followed by - GetOtherReserves(), which among its many side-effects did fix up the rest of the priorities, via a call to ModReserveMinusPriority, which in turn called _FixPriority. However, this got broken because ModReserveMinusPriority now wants a reserve_id to identify the request being changed, but CheckReserves doesn't provide one, because _Findgroupreserve was never updated to provide reserve_id in every situation. *whew* CheckReserve and _Findgroupreserve failing to provide a reserve_id is a bug, but I think a separate one. Upshot: not to preempt QA, but I think Robin's patch is on the right track. However, it's time to take a hard look at GetOtherReserves, which is used only by circ/returns.pl, and see if it is time for that routine to go. At the very, very least, it need a name other than "GetOtherReserves". -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
