http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703
Jonathan Druart <jonathan.dru...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #123 from Jonathan Druart <jonathan.dru...@biblibre.com> --- (In reply to Kyle M Hall from comment #109) QA comments: > (In reply to Galen Charlton from comment #103) > > I suspect regressions of the following bugs may be possible > > > > - 7413 > Katrin filed a followup bug for this since it was not a regression from a > previous release ( i.e. no loss of functionality that 3.14 had ). However, > I've added a followup to take of this. I confirm it fixes the regression. > > - 11486 > > I can find no regression of this bug. I see the number of renewals and > remaining renewals just fine. No regression found. > > - 11711 > > I can find no regression for this issue either. I use the datatables include > for both circulation.tt and moremember.tt No regression found. I didn't found any regression on testing this patch set. I focused on performance: A. 1 Checkout 1. Using the Firebug's network tab a. without the patches GET circulation.pl?borrowernumber=7853 9,0 KB 7,46s 1 requests 8,21s (onload: 14,24s) b. with the patches GET circulation.pl?borrowernumber=7852 8,6 KB 7,53s GET checkouts.pl?borrowernumber=7852 423 B 5,23s 2 requests 12,76s (onload: 14,88s) 2. Using NytProf a. without the patches Profile of /home/koha/src/circ/circulation.pl for 2.76s (of 3.94s), executing 476604 statements and 60325 subroutine calls in 150 source files and 36 string evals. 75% C4::Template::Output 9% get_template_and_user 5% build_issue_data 4% GetPendingIssue b. with the patches Profile of /home/koha/src/circ/circulation.pl for 2.93s (of 4.21s), executing 397152 statements and 61459 subroutine calls in 170 source files and 82 string evals. 57% C4::Template::Output 25% Koha::Schema::Database 7% get_template_and_user 5% DBIx::Class::ResultSet::count Profile of /home/koha/src/svc/checkouts.pl for 296ms (of 345ms), executing 11346 statements and 5019 subroutine calls in 89 source files and 14 string evals. 44% C4::Circulation::CanBookBeRenewed 12% C4::Biblio::GetMarcBiblio B. 10 Checkouts 1. Using the Firebug's network tab a. without the patches GET circulation.pl?borrowernumber=7853 9,9 KB 8,12s 1 request 8,12s (onload: 14,85s) b. with the patches GET circulation.pl?borrowernumber=7853 8,8 KB 7,11s GET checkouts.pl?borrowernumber=7853 1,0 KB 5,77s 2 requests 12,88s (onload: 14,73s) 2. Using NytProf a. without the patches Profile of /home/koha/src/circ/circulation.pl for 4.82s (of 6.83s), executing 561240 statements and 94492 subroutine calls in 150 source files and 36 string evals. 62% C4::Template::Output 25% build_issue_data b. with the patches Profile of /home/koha/src/circ/circulation.pl for 3.59s (of 5.00s), executing 397152 statements and 61459 subroutine calls in 170 source files and 80 string evals. 57% C4::Template::Output 25% Koha::Schema::Database Profile of /home/koha/src/svc/checkouts.pl for 986ms (of 1.22s), executing 60681 statements and 25687 subroutine calls in 89 source files and 14 string evals. 45% C4::Circulation::CanBookBeRenewed 20% Getmarcbiblio => I used a small vm for benchmarking, it's why the loads are quite high. Looking at the results, this new interface won't make waste time to librarians on loading the checkouts page. On checkin/renew, the page won't be reloaded entirely and the time will be divided (at least) by 2 (I let you make the benchmarks). But the "Holds" tab will time consuming, since it will be loaded at the request (on clicking on the tab). I found a small problem on testing, on the "Details" tab (members/moremember.pl), the checkout table don't have the "Loading..." popup, a line "No data available" is displayed. That should be fix, but I don't want to block this feature longer. Kyle, could you please submit a patch on the bug I am going to open please? Katrin has some concerns about accessibility. I don't know if screen readers support this Ajax new screen. It would be great to fix any potential further problem related to accessibility. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/