Paul, I just pushed t/Members_AttributeTypes.t unit tests that fake the > database. The test here could be redundant with t/db_dependent tests > > I feel we should be aware of that, and : > * decide Mock is the way to go, and promote using of Mock, removing > db_dependent tests (that fail if you don't have a database) >
This option is -- in my opinion -- much superior. However, a db_dependent test is better than nothing. > * decide we should prefer db_dependent tests and limit the use of Mock > to specific cases > > I feel that deciding nothing will result in a poor readability of what > tests what, and some difficulties to know which test is to update when > you update a sub. > So, as Mock is introduced, we must speak of it. > I would rather duplicate tests than have untested code. I see no reason for making an absolute decision. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcam...@cpbibliography.com (web) http://www.cpbibliography.com/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
