Am 03.04.2012 06:36, schrieb Srdjan:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Marc,
This patch is wrong. It contains MySQLisms (backquotes). Please change
the code to not introduce MySQLisms, thus supporting the efforts to make
Koha run on PostgreSQL, too.
That is correct. However that line contained MySQLisms before, I did
not introduced them. If the policy is to remove backticks from the code
we change I'm happy to resubmit the patch.
I think it would make greats sense to remove MySQLisms while touching
code. Especially when editing "random" files. What do others think?
Now sysprefs.sql is different, because it uses backquotes everywhere. I
will change that particular file in the not so distant future.
- Marc
Srdjan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk96flEACgkQX6p/D9UE7dw8agCggqf3KiBKRlzoV1Y9wSsRJrKQ
IRkAn3I+PsEUxVZZyJJXBAEwNOfmTInt
=ZjYF
-----END PGP SIGNATURE-----
_______________________________________________
Koha-patches mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
