From: Jonathan Druart <jonathan.dru...@bugs.koha-community.org> The script opac/opac-addbybiblionumber.pl is not plack safe because the variable @biblios is declared with our and is not assigned to an empty array (so not reset).
The issue: When trying to add items to a list (virtualshelf), the biblionumbers are added to the @biblios variable and the list is not reset between each run. Test plan: Check from records from the result list and add them to a list. Cancel or save and re-add them (or others) to a list (same or different). => Without this patch, the list of records will never stop growing, the previous items added are still listed when adding new ones. => With this patch, the behavior is the one expected. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- opac/opac-addbybiblionumber.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opac/opac-addbybiblionumber.pl b/opac/opac-addbybiblionumber.pl index eec38bd..a5decf7 100755 --- a/opac/opac-addbybiblionumber.pl +++ b/opac/opac-addbybiblionumber.pl @@ -38,7 +38,7 @@ our $newvirtualshelf = $query->param('newvirtualshelf'); our $category = $query->param('category'); our $authorized = 1; our $errcode = 0; -our @biblios; +our @biblios = (); # if virtualshelves is disabled, leave immediately if ( ! C4::Context->preference('virtualshelves') ) { -- 2.7.4 _______________________________________________ Koha-patches mailing list Koha-patches@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/