I tried that once & didn't have any luck, but tried it again this morning and it worked. Without cover art, there is now a barely noticeable empty first column and the headers line up with the appropriate data. With cover art, it shows properly and the headers still line up OK. Looks like about the best solution, to leave the <td>s out of the various IFs for content providers and put them before/after those sections. I'll send a new patch.
Thanks. Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 [email protected] -----Original Message----- From: Michael Hafen [mailto:[email protected]] Sent: Thursday, April 23, 2009 2:00 PM To: Wagner, Jane Cc: [email protected] Subject: Re: [Koha-patches] [PATCH] Bug 3152 OPAC reading history column headers don't line up with text My suggestion would be to pull the '<td>' out of the 'TMPL_IF's. On Thu, 2009-04-23 at 12:52 -0400, Wagner, Jane wrote: > Hmm. You may be right on that -- looking at another site with covers, > they insert an extra column in the data rows for the cover. The > template has a bunch of ifs like <!-- TMPL_IF NAME="GoogleJackets" -->. > Maybe I need equiv if statements for the header line? It would be > awfully cumbersome. > > Jane Wagner > Library Systems Analyst > PTFS Inc. > Content Management and Library Solutions > 6400 Goldsboro Road, Suite 200 > Bethesda, MD 20817 > (301) 654-8088 x 151 > [email protected] > > > -----Original Message----- > From: Owen Leonard [mailto:[email protected]] > Sent: Thursday, April 23, 2009 12:17 PM > To: Wagner, Jane > Cc: [email protected] > Subject: Re: [Koha-patches] [PATCH] Bug 3152 OPAC reading history column > headers don't line up with text > > > -<th colspan="2"><!-- TMPL_UNLESS NAME="orderbytitle" --><a > > +<th><!-- TMPL_UNLESS NAME="orderbytitle" --><a > > Has this been tested with book cover images on and off > (OPACAmazonCoverImages, GoogleJackets, etc). I have a feeling the > colspan was designed to account for that and things got out of sync at > some point. > > -- Owen > -- Michael Hafen Systems Analyst and Programmer Washington County School District Utah, USA for Koha checkout http://development.washk12.org/gitweb/ or git://development.washk12.org/koha _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
