On Fri, 24 Apr 2009 15:54:44 -0400 Joe Atzberger <[email protected]> wrote:
> I think SetMarcUnicodeFlag should stay, in part because > BiblioAddAuthorities() should move to a C4 .pm and be used by other > scripts. > > In fact, SetMarcUnicodeFlag should be called earlier in the sub, > before any add_subfields() or field assignments, to avoid munging > unicode data. I can certainly revise things and put the SetMarcUnicodeFlag call back in immediately after MARC::Record->new(). I guess my question would be whether setting the MARC::Record->encoding() there actually has any impact on add_subfields and similar calls. A quick glance at the code made me think that it didn't, but I'm still a very much newbie here. As far as the big picture goes, you're definitely right though. Personally, I would like to see a function like InitializeMarcRecord for new records that would do the MARC::Record->new(), set the encoding, and fill in as many boilerplate fields as we can. But that's a project for another day.... Brian -- Brian Harrington Content and Resource Development Coordinator Project MUSE The Johns Hopkins University Press [email protected] _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
