Hi Owen, This version of the patch sets the ID of all three calendar img elements to "dateofbirth_button", which is incorrect in XHTML, and in FF3 seems to have an odd effect: for the birthday input, you click on the calendar icon to activate the calendar control, but you need to click on the input field of the other two dates to activate the control.
Please fix and resubmit. Also, when you proposed this patch initially, I suggested that it would be a good idea to put the date format hint in an include rather than potentially copy and pasting the TMPL_IF chain for every date field - what do you think of that? Regards, Galen On Sat, May 2, 2009 at 12:54 PM, Owen Leonard <[email protected]> wrote: > --- > .../prog/en/modules/members/memberentrygen.tmpl | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git > a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl > b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl > index fa2aeba..4ee97ce 100644 > --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl > +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl > @@ -214,7 +214,7 @@ > <input type="text" id="dateofbirth" name="dateofbirth" > size="20" value="<!-- TMPL_VAR NAME="dateofbirth" -->" /> > <!-- /TMPL_IF --> > > - <img src="<!-- TMPL_VAR Name="themelang" > -->/lib/calendar/cal.gif" id="dateofbirth_button" alt="Show Calendar" /> > + <img src="<!-- TMPL_VAR Name="themelang" > -->/lib/calendar/cal.gif" id="dateofbirth_button" alt="Show Calendar" /> <!-- > TMPL_IF NAME="us" -->(MM/DD/YYYY)<!-- TMPL_ELSIF NAME="metric" > -->(DD/MM/YYYY)<!-- TMPL_ELSE -->(YYYY/MM/DD)<!-- /TMPL_IF --> > <script language="JavaScript" type="text/javascript"> > Calendar.setup( > { > @@ -735,7 +735,7 @@ > <!-- /TMPL_IF--> > Registration date: </label> > <input type="text" id="dateenrolled" > name="dateenrolled" maxlength="10" size="10" <!-- TMPL_IF NAME="metric" > -->onchange="CheckDate(document.form.dateenrolled);check_manip_date('verify');"<!-- > /TMPL_IF--> value="<!-- TMPL_VAR NAME="dateenrolled" -->" /> > - <img src="<!-- TMPL_VAR Name="themelang" > -->/lib/calendar/cal.gif" id="dateenrolled_button" alt="Show Calendar" /> > + <img src="<!-- TMPL_VAR Name="themelang" > -->/lib/calendar/cal.gif" id="dateofbirth_button" alt="Show Calendar" /> <!-- > TMPL_IF NAME="us" -->(MM/DD/YYYY)<!-- TMPL_ELSIF NAME="metric" > -->(DD/MM/YYYY)<!-- TMPL_ELSE -->(YYYY/MM/DD)<!-- /TMPL_IF --> > <script language="JavaScript" type="text/javascript"> > Calendar.setup( > { > @@ -756,7 +756,7 @@ > <!-- /TMPL_IF--> > Expiry date (leave blank for auto calc) </label> > <input type="text" id="dateexpiry" name="dateexpiry" > maxlength="10" size="10" <!-- TMPL_IF NAME="metric" > -->onchange="CheckDate(document.form.dateexpiry);check_manip_date('verify');"<!-- > /TMPL_IF--> value="<!-- TMPL_UNLESS NAME="opadd" --><!-- TMPL_VAR > NAME="dateexpiry" --><!-- /TMPL_UNLESS -->" /> > - <img src="<!-- TMPL_VAR Name="themelang" > -->/lib/calendar/cal.gif" id="dateexpiry_button" alt="Show Calendar" /> > + <img src="<!-- TMPL_VAR Name="themelang" > -->/lib/calendar/cal.gif" id="dateofbirth_button" alt="Show Calendar" /> <!-- > TMPL_IF NAME="us" -->(MM/DD/YYYY)<!-- TMPL_ELSIF NAME="metric" > -->(DD/MM/YYYY)<!-- TMPL_ELSE -->(YYYY/MM/DD)<!-- /TMPL_IF --> > <script language="JavaScript" type="text/javascript"> > Calendar.setup( > { > -- > 1.5.6.5 > > _______________________________________________ > Koha-patches mailing list > [email protected] > http://lists.koha.org/mailman/listinfo/koha-patches > -- Galen Charlton VP, Research & Development, LibLime [email protected] p: 1-888-564-2457 x709 skype: gmcharlt _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
