Hi Andrei, Thanks for this patch; I've gone ahead and pushed it to HEAD. Please note that I also pushed a followup to replace the use of TMPL_IF EXPR="new_subfield eq 1" with TMPL_IF NAME="new_subfield". Because of the way that HTML::Template::Pro evaluates expressions, any variable referred to in a TMPL_IF EXPR must be be present when the template is parsed, otherwise you get Apache error log warnings like this:
non-initialized variable new_subfield Regards, Galen On Fri, May 22, 2009 at 7:53 AM, Andrei V. Toutoukine <[email protected]> wrote: > modified: > koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl > --- > .../en/modules/admin/marc_subfields_structure.tmpl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git > a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl > b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl > index 59d3104..24ee745 100644 > --- > a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl > +++ > b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl > @@ -89,7 +89,7 @@ > <!-- TMPL_LOOP NAME="loop" --> > <div id="sub<!-- TMPL_VAR NAME="urisubfieldcode" -->field"> > > - <fieldset class="rows"><legend>Basic constraints</legend> > + <fieldset class="rows"><legend><!-- TMPL_IF > EXPR="new_subfield eq 1" -->Add new subfield<!-- TMPL_ELSE -->Basic > constraints<!-- /TMPL_IF --></legend> > <ol> > <!-- TMPL_IF EXPR="subfieldcode eq 0 || > subfieldcode" --> > <li><span class="label">Subfield code:</span> > <!-- TMPL_VAR NAME="subfieldcode" --> <input type="hidden" name="tagsubfield" > value="<!-- TMPL_VAR NAME="subfieldcode" -->" /></li> > -- > 1.5.6.5 > > > _______________________________________________ > Koha-patches mailing list > [email protected] > http://lists.koha.org/mailman/listinfo/koha-patches > -- Galen Charlton VP, Research & Development, LibLime [email protected] p: 1-888-564-2457 x709 skype: gmcharlt _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
