Hi, On Fri, Jul 24, 2009 at 10:04 AM, Nahuel ANGELINETTI<nahuel.angeline...@biblibre.com> wrote: > This fix the user ability to cancel holds in OPAC. > At the moment, a user can cancel all his holds, but in fact, only items that > are not in transfert or waiting to be checked out can be cancelled by the > user.
I disagree with the premise of this patch. Even if an item is in transit or waiting on the hold shelf, why forbid the user to cancel their request if the item is no longer wanted? The user should always be able to signal their intent, and Koha should be smart enough to inform the librarian in case action is required to take the item off the hold shelf or to intercept an item in transit. Even if a library's policy preference is not to allow users to cancel such requests (and what? Force the patron to call the library begging the library to cancel the request? Show up in person?), that is a policy *preference*, and should not be hardcoded. Regards, Galen -- Galen Charlton gmcha...@gmail.com _______________________________________________ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches