Galen,
>From my testing, no warning is visible in the OPAC for items where itemcallnumber is undefined. The value of $itemcallnumber prints as a null string, and thus fails gracefully. Will check the staff client tomorrow. Am I missing a logged warning somewhere? This test was performed on the latest code, synced today. -Ian On Tue, May 4, 2010 at 4:45 PM, Galen Charlton <[email protected]> wrote: > Hi, > > Why take out the test on whether $item->{itemcallnumber} was defined? > Doing so will cause a warning if the call number is null. > > Regards, > > Galen > > On Tue, May 4, 2010 at 4:36 PM, Ian Walls > <[email protected]> wrote: > > From: Brendan A. Gallagher <[email protected]> > > > > Signed-off-by: Ian Walls <[email protected]> > > --- > > C4/XSLT.pm | 5 +++-- > > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/C4/XSLT.pm b/C4/XSLT.pm > > index f1fc9db..ccf6fc2 100644 > > --- a/C4/XSLT.pm > > +++ b/C4/XSLT.pm > > @@ -206,10 +206,11 @@ sub buildKohaItemsNamespace { > > $status = "available"; > > } > > my $homebranch = > $branches->{$item->{homebranch}}->{'branchname'}; > > + my $itemcallnumber = $item->{itemcallnumber}; > > + $itemcallnumber =~ s/\&/\&\;/g; > > $xml.= "<item><homebranch>$homebranch</homebranch>". > > "<status>$status</status>". > > - (defined $item->{'itemcallnumber'} ? > "<itemcallnumber>".$item->{'itemcallnumber'}."</itemcallnumber>" > > - : "<itemcallnumber />") > > + "<itemcallnumber>".$itemcallnumber."</itemcallnumber>" > > . "</item>"; > > > > } > > -- > > 1.5.6.5 > > > > _______________________________________________ > > Koha-patches mailing list > > [email protected] > > http://lists.koha.org/mailman/listinfo/koha-patches > > > > > > -- > Galen Charlton > [email protected] > -- Ian Walls Lead Development Specialist ByWater Solutions ALA Booth # 817 Phone # (888) 900-8944 http://bywatersolutions.com [email protected] Twitter: @sekjal
_______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
