I don't have any profile data, it's just a supposition. I figure it will save however many milliseconds it takes to parse the session data again to form the object.
What I really hope to accomplish with this patch is to fix a strange problem I've been having here. I haven't tested the patch to see if it even accomplishes that yet though, I need to talk to some of my librarians today to see what the results are. The problem is that some stations are logged in an only do circulation, and after a couple hours of active circulation their session is timed out prematurely. I'm just throwing this patch out while testing myself to see what other developers think of it. On Sat, 2010-05-08 at 19:20 -0400, Galen Charlton wrote: > Hi, > > On Thu, May 6, 2010 at 4:43 PM, Michael Hafen <mdha...@tech.washk12.org> > wrote: > > cache the CGI::Session object in C4::Context for the duration of the script. > > This should help pages like circulation.pl which call get_session() again. > > Do you have any profile data to back up your implicit assertion that > this would result in a significant performance improvement? > > Regards, > > Galen -- Michael Hafen Systems Analyst and Programmer Washington County School District Utah, USA for Koha checkout http://development.washk12.org/gitweb/ or git://development.washk12.org/koha _______________________________________________ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches
