Thanks! I was sure there was an explanation for why the code was originally commented out, and a more comprehensive system for determining 'availability' is definitely called for. I had some complaints from folks on our end that the link wasn't working at all, and the functionality I get by adding those lines back in is better for them that otherwise.
I'll temporarily make use of my patch for these folks until a better one is ready. Thanks for the update! -Ian On Tue, May 18, 2010 at 7:08 PM, LAURENT Henri-Damien < henridamien.laur...@biblibre.com> wrote: > Le 19/05/2010 00:04, Ian Walls a écrit : > > From: Ian Walls <ian.wa...@med.nyu.edu> > > > > --- > > C4/Search.pm | 25 ++++++++++++------------- > > 1 files changed, 12 insertions(+), 13 deletions(-) > > > > diff --git a/C4/Search.pm b/C4/Search.pm > > index 229ee40..e7c9c76 100644 > > --- a/C4/Search.pm > > +++ b/C4/Search.pm > > @@ -1256,21 +1256,20 @@ sub buildQuery { > > my $group_OR_limits; > > my $availability_limit; > > foreach my $this_limit (@limits) { > > -# if ( $this_limit =~ /available/ ) { > > -# > > -## 'available' is defined as (items.onloan is NULL) and (items.itemlost > = 0) > > -## In English: > > -## all records not indexed in the onloan register (zebra) and all > records with a value of lost equal to 0 > > -# $availability_limit .= > > -#"( ( allrecords,AlwaysMatches='' not onloan,AlwaysMatches='') and > (lost,st-numeric=0) )"; #or ( allrecords,AlwaysMatches='' not > lost,AlwaysMatches='')) )"; > > -# $limit_cgi .= "&limit=available"; > > -# $limit_desc .= ""; > > -# } > > -# > > + if ( $this_limit =~ /available/ ) { > > + > > +# 'available' is defined as (items.onloan is NULL) and (items.itemlost = > 0) > > +# In English: > > +# all records not indexed in the onloan register (zebra) and all records > with a value of lost equal to 0 > > + $availability_limit .= > > +"( ( allrecords,AlwaysMatches='' not onloan,AlwaysMatches='') and > (lost,st-numeric=0) )"; #or ( allrecords,AlwaysMatches='' not > lost,AlwaysMatches='')) )"; > > + $limit_cgi .= "&limit=available"; > > + $limit_desc .= ""; > > + } > > + > > # group_OR_limits, prefixed by mc- > > # OR every member of the group > > -# elsif ( $this_limit =~ /mc/ ) { > > - if ( $this_limit =~ /mc/ ) { > > + elsif ( $this_limit =~ /mc/ ) { > > $group_OR_limits .= " or " if $group_OR_limits; > > $limit_desc .= " or " if $group_OR_limits; > > $group_OR_limits .= "$this_limit"; > Hi Ian. > Nahuel will work on a real fix for availability. > Since at the moment customers are complaining (quite fairly) that > availability cannot be at biblio level but should rather be at item level. > And they are correct. > But When indexing elements only at biblio level, we cannot provide them > with the best accurate information. > So Nahuel already did some work on that. > But it need some improvement, which he will do soon. > _______________________________________________ > Koha-patches mailing list > Koha-patches@lists.koha.org > http://lists.koha.org/mailman/listinfo/koha-patches > -- Ian Walls Lead Development Specialist ByWater Solutions ALA Booth # 817 Phone # (888) 900-8944 http://bywatersolutions.com ian.wa...@bywatersolutions.com Twitter: @sekjal
_______________________________________________ Koha-patches mailing list Koha-patches@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-patches