On Tuesday 10 October 2006 19:28, Rafael Fernández López wrote: > Hi folks, > > Talking about Kopete trunk. In > kdenetwork/kopete/kopete/config/accounts/kopeteaccountconfig.cpp I've been > trying to understand what > > connect( m_addwizard, SIGNAL( destroyed( QObject * ) ), this, SLOT( > slotAddWizardDone() ) ); > > exactly does but I think it has no point for standing here. > > What I mean is that when adding a new account succesfully, that account is > not innmediatly added to the account list, and you have to close the > account list window, and reopen it in order to see the new account appear. > So it is not doing what we would expect from it. > > Thinking about it in other way, I'd say that slotAddWizardDone() only > should be called when the account has been successfully created, that is, > when the signal finished() is received from m_addwizard. If we close the > wizard, that slot *shouldn't* be called, since no changes will happen on > the account list. > > This patch will innmediatly add (when Finish button is clicked in wizard) > the account to the list account, and slotAddWizardDone() won't be called if > the wizard was closed. > > If I have commited any errors, please tell me. > > Thank you, > Rafael Fernández López.
This patch looks fine. Do you have an SVN account yet? If so, please commit. -- Matt _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
