Thank you for entering the listen support into a branch.
Concerning the DBUS issues. Firstly, I realize that the current configure file is ugly, but unfortunately I won't be able to fix it in the near future. I will fix it if nobody takes this issue, but it can take some time, as I'm busy with other tasks. Secondly, I think it's safe to call dbus_pending_call_block, because firstly we called dbus_connection_send_with_reply with a timeout of -1, meaning "a sane default timeout" (taken out of the dbus documentation). IMO, if listen crashes before it sends a reply message, dbus will wait this amount of time and catch the error reply with dbus_pending_call_steal_reply. The return value will be NULL, and in this case the function will return after logging it with kdDebug. Thanks for the tip about the svn branches. I'm pretty new to all of this. :) 2007/1/24, Will Stephenson <[EMAIL PROTECTED]>:
On Monday 15 January 2007 20:34, Tomer Haimovich said: > A long long time ago I thought about coding a Kopete Now Listening support > in Gnome's Listen audio player. Listen is aimed to be the Gnome alternative > for Amarok. Today, I'm proud to announce that Listen support is > implemented! Great! Thanks for working on it. I have made an svn branch of the 3.5 nowlistening plugin at $SVNROOT/branches/work/kopete/nowlistening_extra . This will contain your Listen support and also a Quod Libet patch that I wrote a while ago. If 3.5 branch unfreezes again I will merge it into BRANCH proper. > The communication is done, of course, using DBUS. I actually think that > this is the first now listening interface to use DBUS, mainly because I had > no other way: Listen is a gnome application, build in Python, and it > doesn't support dcop. DBus is fine, but we need a configure check for the dbus headers before this patch could be merged. Also, are you sure that the blocking dbus call is safe for Kopete to use? I've only used async dbus with the glib bindings, so I don't know what the risk is if Listen falls over while handling the call. > I started working on this extension using the 0.12.2 source code. I just > couldn't get a SVN version working. Therefore, some new SVN changes might > not appear in the diff files. I'll list the few changes in the > nowlistening*.cpp files here, so the developer who puts it in won't hate > me. > > :) Most of the work is done in new files anyway, nllisten.cpp, nllisten.h. > > Changes: > In nowlisteningpreferences.cpp: Looking at your patch files, it appears you diffed the clean trunk sources (IE kde 4) with your modified branch sources. Not a good idea. NB. You have a patch per file. I recommend you work on a checkout of 3.5 branch svn, that way you can svn diff the nowlistening dir and get all the changes in one diff. regards Will
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
