Matt Rogers wrote: >On Jan 29, 2007, at 3:53 PM, Thiago Macieira wrote: >> Matt Rogers wrote: >>> The slot was virtual before, let's just leave it as is for right now. >> >> They should all be changed in the future then. Qt already >> handles "virtualness" in slots by itself. No need to add to the >> virtual >> table and create more relocations. > >Except for the cases where the slots are called directly. To me, the >QMetaObject::invokeMethod thing is just a hack when we can call the >slot manually.
If they are not being called directly, they shouldn't be virtual. Consider using Q_PRIVATE_SLOT too. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
pgpZB8wBdWwzh.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
