Le March 5, 2007 06:37, Bruno Virlet a écrit : > Hello, > > This is a patch which ports the tooltip edition dialog to Qt4. > > Bruno
The patch is fine except for these points: - Respect the original indentation of the file, you used spaces but the original used tabs - " connect(unusedItemsListView, SIGNAL(doubleClicked ( const QModelIndex& index )), this, SLOT(slotAddButton())); connect(usedItemsListView, SIGNAL(doubleClicked ( const QModelIndex& index )), this, SLOT(slotRemoveButton())); " the SIGNAL() is wrong ;) no need to include <QSortFilterModel> in header, it's only needed in implementation. Apart from that, thanks for your work :) -- Michaël Larouche KDE developer working on Kopete, Gamefu(KDE), Solid...on dial-up :P -------------------------------------- Website: http://www.tehbisnatch.org/ MSN: [EMAIL PROTECTED] IRC: irc.freenode.org/DarkShock Jabber/email: [EMAIL PROTECTED]
pgp31UR12uwIU.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
