Le dimanche 8 avril 2007, Charles Connell a écrit : > On Sunday 08 April 2007 04:56, Olivier Goffart wrote:
> > Why did you change some QLatin1String to QString::fromLatin1 ? > > I didn't do that, someone else did between the 3rd developer snapshot and > now oh, ok. You probably should use subversion, so we can really see your diff. Also you should get a subversion account if you want to start to contribute. > > in setBody( QTextDocument , MessageFormat ) , the default argument of > > MessageFormat should be richtext. i would say it is not even required to > > add the MessageFormat argument. > > Ok for the default suggestion > > I think the parameter should be left in because if someone wants to specify > the body and the format, how else would they do it? (unless we add a > setMessageFormat() method) QTextDocument contains already the format information. I would get ride completely of the format. > but Message defines more types than > TextFormat offers (like ParsedHTML and Crypted). Parsed HTML is an internal flag, and we should get ride of that in the public API And crypted is not used in KDE3, and i've made the classes for that in KDE4, so we could get ride of that. > I don't really see how setHtmlBody and setPlainBody would lead to any fewer > errors, since it's really the same as setBody in that the caller still has > to know what kind of string they are passing. I've seen lot of case where a developper misused setBody (using the incorrect format) I think that having the format in the function name will help
pgpUwDxLwq9IL.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
