-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Nov 11, 2007, at 10:06 AM, Jan Ritzerfeld wrote: > Am Samstag, 10. November 2007 schrieb Will Stephenson: > >> ------- You are receiving this mail because: ------- >> You are the assignee for the bug, or are watching the assignee. >> >> http://bugs.kde.org/show_bug.cgi?id=152127 >> Summary: tray flashes irrespective of Enable events for >> active >> chat windows setting >> Product: kopete >> Version: 0.40.0 >> Platform: Compiled Sources >> OS/Version: Linux >> Status: NEW >> Severity: normal >> Priority: NOR >> Component: Main Application >> AssignedTo: kopete-devel kde org >> ReportedBy: wstephenson kde org >> >> >> Version: 0.40.0 (using KDE Devel) >> Installed from: Compiled sources >> >> The system tray flashes on all new messages, even if there is >> already an >> active chat window. This should be controlled by the "Enable >> events for >> active chat windows" setting. I've looked at the code in >> kopetesystemtray.cpp and I don't see how to get the state "is >> there an >> active chat window" from the KopeteMessageEvent. >> >> In 3.5 this worked but was apparently due to a check on the number of >> balloon events vs tray events, > > IIRC this is not 100% correct. In r463970 I added the check > comparing these > events while implementing the balloon timeout feature. Before, > there was no > comparison, just a simple startBlink call. > > However, AFAIK the "Enable events for active chat windows" setting > does not > affect message queueing/stacking (that is, neither the balloon nor > the tray > flash) even in 3.5! > >> which seems like it is happening at the >> wrong level, and anyway we don't have the balloon in 4.0. > > In 3.5, the decision whether to queue/stack a message or not is > somewhat > hardcoded in KopeteViewManager::messageAppended. Actually, there are > several checks: is a chat window already there? if so, is it > active? if so, > is the chat view in the active chat window active? > > HTH > Jan > _______________________________________________ > kopete-devel mailing list > kopete-devel@kde.org > https://mail.kde.org/mailman/listinfo/kopete-devel This needs to be in the bugzilla comment log as well. Please post it there. - -- Matt -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFHN+B6A6Vv5rghv0cRAgmEAJ4wQzAQDl74IkG3CeGxNEm7EJzK5gCgpvjx U8BHdDVed5rY7Q/Rq/xdWcc= =G8Er -----END PGP SIGNATURE----- _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
