Le samedi 12 janvier 2008, Roman Jarosz a écrit : > Hi, > > this is the "final" version of Status Manager that I want to commit to > trunk tomorrow if nobody objects. > > Changes from previous version > * Added default statuses when Kopete is started for the first time. > * Added code comments, I know that there are still some comments that are > missing, I will add it later. > > Btw I've also done some usability testing with Kopete at school and the > results for Status Manager were very good. > > Regards, > Roman
By quickly looking the code, i see this problem : + static QPixmap pixmapForCategory( Categories category ); Maybe you should return a KIcon there. Otherwhise the pixmap may have the wrong size. We did that mistake for the OnlineStatus, (and i am going to fix it) Lots of classes lack a class description in the documentation. Also, I did not check carefully, but it seems to me that some class should not belong to libkopete, but be in the application instead. Please ask yourself "is that class really required to be in libkopete" for every class you add. Remember that if it's in libkopete, we will havee to maintain compatibility if ever we reach Kopete 1.0 We also, in libkopete, have Kopete::Status* and Kopete::OnlineStatus* classes. I think i understand the difference (Status is a generic container for a metacontact/identity), and OnlineStatus is for managing the protocol status of subcontact/accounts and their icon) The same word is used for two different thing. a rename is required. I will think about suggestions. :-)
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
