----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/144/#review140 -----------------------------------------------------------
Ship it! Looks good (I have the same fix in my local svn since yesterday :( ), maybe you can remove fill and use constructor QByteArray bytes(4, '\0'); but it's up to you. Please commit. PS. Don't forget to backport it. - Roman On 2008-02-16 08:12:54, Carlo Segato wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://mattr.info/r/144/ > ----------------------------------------------------------- > > (Updated 2008-02-16 08:12:54) > > > Review request for Kopete. > > > Summary > ------- > > this patch fixes the sending of the user picture to other clients and maybe > other things that use slotSendData > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/msn/outgoingtransfer.cpp > trunk/KDE/kdenetwork/kopete/protocols/msn/p2p.cpp > > Diff: http://mattr.info/r/144/diff > > > Testing > ------- > > tested with kopete 0.12/pidgin/live messenger 8.1 > > > Thanks, > > Carlo > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
