----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/#review225 -----------------------------------------------------------
Ship it! Looks good now. Thanks! :) Be sure to fix the whitespace issue (marked in red in the diffs) before you commit - Matt On 2008-02-24 16:48:57, Charles Connell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://mattr.info/r/171/ > ----------------------------------------------------------- > > (Updated 2008-02-24 16:48:57) > > > Review request for Kopete. > > > Summary > ------- > > This is a patch that resizes the main window automatically, so that it nicely > fits the size of the contact list tree. This is set up as an off-by-default > option. It will never get taller than the size of the user's desktop, and it > will never get shorter than 400 pixels. > > 1000 milliseconds after a contact enters/leaves the visible contact list, the > window resizes. We wait 1000 milliseconds in case a significant number of > contacts are appearing/disappearing at once and we only want to resize once. > Also, it will not resize if the user's cursor is inside the main window, as > this would likely cause undue frustration. > > Advantages: - Always a nicely presented main window. > - Keep up with feature sets in competitors (some of them already > have this). > > Disadvantages: - If window is visible to user, it is distracting to see it > resizing spontaneously. > > Of course, this is all off by default, and even if the setting is enabled, it > only takes effect when the main window is maximized. > > User has two config options: > 1) Enable/disable automatic resizing > 2) Anchor resizing at top or bottom of window > > > This addresses bug 154955. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/kopete/config/appearance/appearanceconfig.cpp > > trunk/KDE/kdenetwork/kopete/kopete/config/appearance/appearanceconfig_advanced.ui > trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.h > trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp > trunk/KDE/kdenetwork/kopete/libkopete/kopeteappearancesettings.kcfg > trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistview.h > trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistviewitem.h > trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistviewitem.cpp > > Diff: http://mattr.info/r/171/diff > > > Testing > ------- > > works for me after during a few minutes of testing > > > Screenshots > ----------- > > Config options rev. 3 > http://mattr.info/r/171/s/20/ > > > Thanks, > > Charles > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
