Hi Matt! Yes, I commited it after Dennis had reviewed the patch. Gof already reverted those changes, but the separate patch is probably the best way. Shall I just create the patch and send it to the list? Or what am I supposed to do?
Best regards, Dominik Am Dienstag 12 August 2008 17:17:44 schrieb Matt Rogers: > On Aug 12, 2008, at 6:34 AM, Dominik Schmidt wrote: > > Hi! > > Here's another patch of mine, this time it's for wrong/missing > > copyright > > notations. > > I fixed the copyright notation style in the sms protocol and added > > Justin > > Karneges' email where needed in the Kopete tree. > > > > I'm not sure what I did for kopete_unix_serial.cpp was the correct > > way so pay > > especial attention there (FYI krazy2 expects the "Copyright (c) by" > > string). > > > > Can I tell "svn diff" not to diff a certain directory? > > For now you get a monster patch with all stuff and a smaller one > > only for the > > sms protocol (it's part of the monster patch). ;-) > > > > > > Best regards, > > Dominik > > > > P.S.:The patch also contains two small fixes I forgot to commit last > > time. > > P.P.S.: My svnaccount has been setup so I can commit myself if you > > want me to. > > > > ---------- Weitergeleitete Nachricht ---------- > > > > Betreff: Re: email address for copyright notation > > Datum: Dienstag 12 August 2008 > > Von: Justin Karneges <[EMAIL PROTECTED]> > > An: Dominik Schmidt <[EMAIL PROTECTED]> > > > > On Monday 11 August 2008 03:57:09 you wrote: > >> Hi! > >> I'm trying to fix some minor "bugs" in kopete of which are missing > >> email > >> adresses like yours (the string "Based on Iris, Copyright (C) 2003 > >> Justin > >> Karneges" occurs rather often ;-)). > >> > >> So my question is: > >> Could you tell me an email address I can add to the source code to be > >> compliant with KDE guidelines? > > > > Hi Dominik, > > > > [EMAIL PROTECTED] is the right address to use. > > > > -Justin > > > > ------------------------------------------------------- > > > > Am Montag 11 August 2008 19:14:51 schrieb Dennis Nienhüser: > >> Hi Domme, > >> > >> looks good. Just commited it, thanks :-) > >> > >> Dennis > >> > >> Dominik Schmidt schrieb: > >>> Moin, > >>> finally this is my first actual commit :D > >>> I corrected several typos and contractions in Kopete's source > >>> found by > >>> englishbreakfastnetwork. > >>> > >>> So please check if I made anything worse than before and put it on > >>> SVN if > >>> it's ok. > >>> > >>> Best regards, > >>> Domme > > It looks like you already committed this, but the libiris parts need a > separate patch that can be applied to libiris. The separate patch is > needed because we'll get errors again when resyncing libiris from the > PSI repository. > -- > Matt > > _______________________________________________ > kopete-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kopete-devel _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
