Le vendredi 3 octobre 2008, David Faure a écrit : > On Thursday 02 October 2008, David Faure wrote: > > when joining a groupchat and getting past discussion, all the lines from > > people who are not in the chat anymore are missing! > > This is due to the "return;" in jabbergroupcontact.cpp line 193, but svn > > annotate only tells me it was merged from 0.12 branch by mlarouche. > > I'm not sure why it's looking for groupchatname/nick instead of just the > > nick (which is in the contact list), apparently there is no > > groupchatname/nick when that nick isn't in the group chat at a given > > time. > > In any case, if I just remove that "return" statement, then everything > > works fine, I see the replayed lines from everyone again. > > Any objections against this patch? (extra context added for clarity) > The current "data loss" is not so nice.
It looks correct.
The svn log says something about the irc gateway. But this was probably just
commited by mistake. Can you maybe try if that still works with the irc
gateway?
> --- protocols/jabber/jabbergroupcontact.cpp (revision 867253)
> +++ protocols/jabber/jabbergroupcontact.cpp (working copy)
> @@ -189,8 +189,7 @@ void JabberGroupContact::handleIncomingM
>
> if ( !subContact )
> {
> - kWarning (JABBER_DEBUG_GLOBAL) << "the contact is
> not in the list : " << message.from().full(); -
> return;
> + kDebug (JABBER_DEBUG_GLOBAL) << "the contact is not
> in the list : " << message.from().full(); /**
> * We could not find the contact for this message.
> That most likely means * that it originated from a history backlog or
> something similar and * the sending person is not in the channel anymore.
> We need to create * a new contact for this which does not show up in the
> manager. */
> subContact = addSubContact ( XMPP::RosterItem (
> message.from () ), false ); }
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
