----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/486/#review748 -----------------------------------------------------------
The code looks good just one thought, this code is speed critical so it would be better if we filtered the items only once (during the width calculation) and during painting we should use the cached list. - Roman On 2009-03-30 22:04:49, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/486/ > ----------------------------------------------------------- > > (Updated 2009-03-30 22:04:49) > > > Review request for Kopete. > > > Summary > ------- > > When hide offline contacts is in effect, offline contacts should be hidden > even if the metacontact is online. So only the online contacts (of the > metacontact) should be shown. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.h 947102 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp > 947102 > > Diff: http://reviewboard.kde.org/r/486/diff > > > Testing > ------- > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
