Em Tuesday 14 July 2009, Detlev Casanova escreveu:
> > On 2009-07-14 20:53:05, Detlev Casanova wrote:
> > > Please provide a patch
>
> Please provide a patch in
> /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris for all changes made
> in that directory. Read
> /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/README_BEFORE_COMMITT
>ING before committing :-)
Do you want me to open a new review request with the patch to libiris
alone
or to commit the changes to libiris or both? I already have write access to
KDE's svn repository.
> (sorry for the double post, konqueror has troubles with the Review Board)
>
>
> - Detlev
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1004/#review1597
> -----------------------------------------------------------
>
> On 2009-07-14 20:00:08, Lamarque Souza wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1004/
> > -----------------------------------------------------------
> >
> > (Updated 2009-07-14 20:00:08)
> >
> >
> > Review request for Kopete.
> >
> >
> > Summary
> > -------
> >
> > Initialise deleted pointers to 0L. Throughout all Kopete source code
> > pointers are deleted and not initialized, grep -r 'delete ' $(find \(
> > -name "*.cpp" -o -name "*.h" \) ) | wc returns 1105 lines, I can do a
> > rough estimation of at least half of those lines do not reinitialize
> > pointers. Althouth reinitialing pointers are not always necessary in some
> > cases it does is necessary and by what I have seen there are such places
> > in Kopete's source code. Kopete::CommandHandler::slotExecFinished even
> > passed one deleted pointer to a function, which seems really wrong to me,
> > it should delete the pointer after calling the function, not before. To
> > illustrate the problem assume a is a class member pointer:
> >
> > delete a; // in one class method
> >
> > // In another class method:
> > if (a) // the result will the true even though a is deleted
> > do a->"something" // this can crash the application
> >
> >
> > Diffs
> > -----
> >
> > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecommandhandler.cpp 993925
> >
> > /trunk/KDE/kdenetwork/kopete/protocols/groupwise/libgroupwise/coreprotoco
> >l.cpp 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/irc/irccontact_channel.cpp 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jingle/jinglertpsession.cpp
> > 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/irisnet/coreli
> >b/netinterface.cpp 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/jingle/ji
> >nglecontent.cpp 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/jingle/ji
> >nglesessionmanager.cpp 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-core
> >/parser.cpp 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgahclist.cpp 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabberregister.cpp
> > 993925 /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgregister.cpp
> > 993925 /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgsearch.cpp
> > 993925
> > /trunk/KDE/kdenetwork/kopete/protocols/sms/smseditaccountwidget.cpp
> > 993925
> >
> > Diff: http://reviewboard.kde.org/r/1004/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Lamarque
--
Lamarque V. Souza
http://www.geographicguide.com/brazil.htm
Linux User #57137 - http://counter.li.org/
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
