> On 2009-08-25 18:20:01, Raphael Kubo da Costa wrote: > > Running svn log tells us that the icon was renamed in 2007... The patch > > looks fine, even though the "Testing done" field was blank. I suppose > > you've tested it, right? > > Markus Slopianka wrote: > Still not marked as submitted...
... because you didn't submit it? ;) The "Testing done" field is still blank, so it should be updated. After that, if it does work, you need to commit it and mark as Submitted. Do you have commit access? - Raphael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1403/#review2145 ----------------------------------------------------------- On 2009-08-25 18:16:02, Markus Slopianka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1403/ > ----------------------------------------------------------- > > (Updated 2009-08-25 18:16:02) > > > Review request for Kopete. > > > Summary > ------- > > The context menu entry for "Add to Your Contact List" is missing an icon -- > probably because name of the icon changed in 4.3. > This patch is for trunk. If possible, apply it to 4.3 branch as well. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp/. 1015503 > > Diff: http://reviewboard.kde.org/r/1403/diff > > > Testing > ------- > > > Thanks, > > Markus > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
